diff options
| author | Dave Chinner <dchinner@redhat.com> | 2017-10-09 11:37:23 -0700 |
|---|---|---|
| committer | Darrick J. Wong <darrick.wong@oracle.com> | 2017-10-11 10:21:06 -0700 |
| commit | 67f2ffe31d1a683170c2ba0ecc643e42a5fdd397 (patch) | |
| tree | 2acf8db2af000b61a418b2041e67531fd9ab24cf /lib | |
| parent | bb9c2e5433250f5b477035dc478314f8e6dd5e36 (diff) | |
xfs: don't change inode mode if ACL update fails
If we get ENOSPC half way through setting the ACL, the inode mode
can still be changed even though the ACL does not exist. Reorder the
operation to only change the mode of the inode if the ACL is set
correctly.
Whilst this does not fix the problem with crash consistency (that requires
attribute addition to be a deferred op) it does prevent ENOSPC and other
non-fatal errors setting an xattr to be handled sanely.
This fixes xfstests generic/449.
Signed-Off-By: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Diffstat (limited to 'lib')
0 files changed, 0 insertions, 0 deletions