diff options
| author | Pavel Begunkov <asml.silence@gmail.com> | 2021-01-26 23:35:10 +0000 |
|---|---|---|
| committer | Jens Axboe <axboe@kernel.dk> | 2021-01-26 19:36:55 -0700 |
| commit | 907d1df30a51cc1a1d25414a00cde0494b83df7b (patch) | |
| tree | 4f4c77ff3eab78ccc44536dc01c21b6b8000127c /lib/crc64.c | |
| parent | ca70f00bed6cb255b7a9b91aa18a2717c9217f70 (diff) | |
io_uring: fix wqe->lock/completion_lock deadlock
Joseph reports following deadlock:
CPU0:
...
io_kill_linked_timeout // &ctx->completion_lock
io_commit_cqring
__io_queue_deferred
__io_queue_async_work
io_wq_enqueue
io_wqe_enqueue // &wqe->lock
CPU1:
...
__io_uring_files_cancel
io_wq_cancel_cb
io_wqe_cancel_pending_work // &wqe->lock
io_cancel_task_cb // &ctx->completion_lock
Only __io_queue_deferred() calls queue_async_work() while holding
ctx->completion_lock, enqueue drained requests via io_req_task_queue()
instead.
Cc: stable@vger.kernel.org # 5.9+
Reported-by: Joseph Qi <joseph.qi@linux.alibaba.com>
Tested-by: Joseph Qi <joseph.qi@linux.alibaba.com>
Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'lib/crc64.c')
0 files changed, 0 insertions, 0 deletions