summaryrefslogtreecommitdiff
path: root/kernel
diff options
context:
space:
mode:
authorPali Rohár <pali@kernel.org>2024-09-29 12:22:40 +0200
committerSteve French <stfrench@microsoft.com>2024-10-03 12:05:12 -0500
commite2a8910af01653c1c268984855629d71fb81f404 (patch)
tree54e3e08290deb44ee2e237d95abcc593bbe5c793 /kernel
parente9f49feefb4b13b36441aae51649a67a8389bd40 (diff)
cifs: Fix buffer overflow when parsing NFS reparse points
ReparseDataLength is sum of the InodeType size and DataBuffer size. So to get DataBuffer size it is needed to subtract InodeType's size from ReparseDataLength. Function cifs_strndup_from_utf16() is currentlly accessing buf->DataBuffer at position after the end of the buffer because it does not subtract InodeType size from the length. Fix this problem and correctly subtract variable len. Member InodeType is present only when reparse buffer is large enough. Check for ReparseDataLength before accessing InodeType to prevent another invalid memory access. Major and minor rdev values are present also only when reparse buffer is large enough. Check for reparse buffer size before calling reparse_mkdev(). Fixes: d5ecebc4900d ("smb3: Allow query of symlinks stored as reparse points") Reviewed-by: Paulo Alcantara (Red Hat) <pc@manguebit.com> Signed-off-by: Pali Rohár <pali@kernel.org> Signed-off-by: Steve French <stfrench@microsoft.com>
Diffstat (limited to 'kernel')
0 files changed, 0 insertions, 0 deletions