summaryrefslogtreecommitdiff
path: root/kernel/power
diff options
context:
space:
mode:
authorStefano Garzarella <sgarzare@redhat.com>2022-06-22 17:14:07 +0200
committerMichael S. Tsirkin <mst@redhat.com>2022-06-27 08:05:35 -0400
commit037d4305569aacaa018a617771dccbb81cc60257 (patch)
tree919ee4726f1a48e71115e85381a47521dcfe8f20 /kernel/power
parente0c2ce8217955537dd5434baeba061f209797119 (diff)
vhost-vdpa: call vhost_vdpa_cleanup during the release
Before commit 3d5698793897 ("vhost-vdpa: introduce asid based IOTLB") we call vhost_vdpa_iotlb_free() during the release to clean all regions mapped in the iotlb. That commit removed vhost_vdpa_iotlb_free() and added vhost_vdpa_cleanup() to do some cleanup, including deleting all mappings, but we forgot to call it in vhost_vdpa_release(). This causes that if an application does not remove all mappings explicitly (or it crashes), the mappings remain in the iotlb and subsequent applications may fail if they map the same addresses. Calling vhost_vdpa_cleanup() also fixes a memory leak since we are not freeing `v->vdev.vqs` during the release from the same commit. Since vhost_vdpa_cleanup() calls vhost_dev_cleanup() we can remove its call from vhost_vdpa_release(). Fixes: 3d5698793897 ("vhost-vdpa: introduce asid based IOTLB") Cc: gautam.dawar@xilinx.com Signed-off-by: Stefano Garzarella <sgarzare@redhat.com> Message-Id: <20220622151407.51232-1-sgarzare@redhat.com> Signed-off-by: Michael S. Tsirkin <mst@redhat.com> Tested-by: Eugenio PĂ©rez <eperezma@redhat.com> Acked-by: Jason Wang <jasowang@redhat.com>
Diffstat (limited to 'kernel/power')
0 files changed, 0 insertions, 0 deletions