summaryrefslogtreecommitdiff
path: root/kernel/dma
diff options
context:
space:
mode:
authorKefeng Wang <wangkefeng.wang@huawei.com>2021-07-22 18:55:12 +0800
committerChristoph Hellwig <hch@lst.de>2021-08-09 17:03:17 +0200
commit1d7db834a027ecfb5ac93be2e8bb45bfcbbf6eaa (patch)
treeb41acc0ce44f9f892f0e060bc007ada40c7b63ec /kernel/dma
parent36a21d51725af2ce0700c6ebcb6b9594aac658a6 (diff)
dma-debug: use memory_intersects() directly
There is already a memory_intersects() helper in sections.h, use memory_intersects() directly instead of private overlap(). Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com> Signed-off-by: Christoph Hellwig <hch@lst.de>
Diffstat (limited to 'kernel/dma')
-rw-r--r--kernel/dma/debug.c14
1 files changed, 2 insertions, 12 deletions
diff --git a/kernel/dma/debug.c b/kernel/dma/debug.c
index dadae6255d05..fe6efd181614 100644
--- a/kernel/dma/debug.c
+++ b/kernel/dma/debug.c
@@ -1064,20 +1064,10 @@ static void check_for_stack(struct device *dev,
}
}
-static inline bool overlap(void *addr, unsigned long len, void *start, void *end)
-{
- unsigned long a1 = (unsigned long)addr;
- unsigned long b1 = a1 + len;
- unsigned long a2 = (unsigned long)start;
- unsigned long b2 = (unsigned long)end;
-
- return !(b1 <= a2 || a1 >= b2);
-}
-
static void check_for_illegal_area(struct device *dev, void *addr, unsigned long len)
{
- if (overlap(addr, len, _stext, _etext) ||
- overlap(addr, len, __start_rodata, __end_rodata))
+ if (memory_intersects(_stext, _etext, addr, len) ||
+ memory_intersects(__start_rodata, __end_rodata, addr, len))
err_printk(dev, NULL, "device driver maps memory from kernel text or rodata [addr=%p] [len=%lu]\n", addr, len);
}