diff options
| author | Pavel Begunkov <asml.silence@gmail.com> | 2024-07-24 12:16:21 +0100 |
|---|---|---|
| committer | Jens Axboe <axboe@kernel.dk> | 2024-07-24 08:01:49 -0600 |
| commit | 29d63b94036e561a016ec8878b44aad6650d23e2 (patch) | |
| tree | 33ce3375ca93106837a479ab15b46b246ec7dd10 /io_uring/io_uring.c | |
| parent | a2b72b81fb3ba18717fc000949ca9d45a3351130 (diff) | |
io_uring: align iowq and task request error handling
There is a difference in how io_queue_sqe and io_wq_submit_work treat
error codes they get from io_issue_sqe. The first one fails anything
unknown but latter only fails when the code is negative.
It doesn't make sense to have this discrepancy, align them to the
io_queue_sqe behaviour.
Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
Link: https://lore.kernel.org/r/c550e152bf4a290187f91a4322ddcb5d6d1f2c73.1721819383.git.asml.silence@gmail.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'io_uring/io_uring.c')
| -rw-r--r-- | io_uring/io_uring.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/io_uring/io_uring.c b/io_uring/io_uring.c index 10c409e56241..2626424f5d73 100644 --- a/io_uring/io_uring.c +++ b/io_uring/io_uring.c @@ -1849,7 +1849,7 @@ fail: } while (1); /* avoid locking problems by failing it from a clean context */ - if (ret < 0) + if (ret) io_req_task_queue_fail(req, ret); } |