summaryrefslogtreecommitdiff
path: root/fs/notify
diff options
context:
space:
mode:
authorAlan Stern <stern@rowland.harvard.edu>2020-07-06 11:14:36 -0400
committerMartin K. Petersen <martin.petersen@oracle.com>2020-07-24 22:09:55 -0400
commit8f38f8e0a30e1c33cdfc48eba2bd63ac2eae373a (patch)
treedc5d4b4b9f4e0fec9caf350588785ad8a76b6a1e /fs/notify
parentdf4ec2fa7a4dc20bed62a407f77b5c57f1afbbc8 (diff)
scsi: block: pm: Simplify resume handling
Commit 05d18ae1cc8a ("scsi: pm: Balance pm_only counter of request queue during system resume") fixed a problem in the block layer's runtime-PM code: blk_set_runtime_active() failed to call blk_clear_pm_only(). However, the commit's implementation was awkward; it forced the SCSI system-resume handler to choose whether to call blk_post_runtime_resume() or blk_set_runtime_active(), depending on whether or not the SCSI device had previously been runtime suspended. This patch simplifies the situation considerably by adding the missing function call directly into blk_set_runtime_active() (under the condition that the queue is not already in the RPM_ACTIVE state). This allows the SCSI routine to revert back to its original form. Furthermore, making this change reveals that blk_post_runtime_resume() (in its success pathway) does exactly the same thing as blk_set_runtime_active(). The duplicate code is easily removed by making one routine call the other. No functional changes are intended. Link: https://lore.kernel.org/r/20200706151436.GA702867@rowland.harvard.edu CC: Can Guo <cang@codeaurora.org> CC: Bart Van Assche <bvanassche@acm.org> Reviewed-by: Bart Van Assche <bvanassche@acm.org> Signed-off-by: Alan Stern <stern@rowland.harvard.edu> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Diffstat (limited to 'fs/notify')
0 files changed, 0 insertions, 0 deletions