diff options
author | Jan Kara <jack@suse.cz> | 2015-05-21 16:05:55 +0200 |
---|---|---|
committer | Al Viro <viro@zeniv.linux.org.uk> | 2015-06-23 18:01:09 -0400 |
commit | 45f147a1bc97c743c6101a8d2741c69a51f583e4 (patch) | |
tree | b7919ca80674bc1793b4423957f4d61c8100408d /fs/minix/minix.h | |
parent | dbfae0cdcd87602737101d4417811f4323156b54 (diff) |
fs: Call security_ops->inode_killpriv on truncate
Comment in include/linux/security.h says that ->inode_killpriv() should
be called when setuid bit is being removed and that similar security
labels (in fact this applies only to file capabilities) should be
removed at this time as well. However we don't call ->inode_killpriv()
when we remove suid bit on truncate.
We fix the problem by calling ->inode_need_killpriv() and subsequently
->inode_killpriv() on truncate the same way as we do it on file write.
After this patch there's only one user of should_remove_suid() - ocfs2 -
and indeed it's buggy because it doesn't call ->inode_killpriv() on
write. However fixing it is difficult because of special locking
constraints.
Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'fs/minix/minix.h')
0 files changed, 0 insertions, 0 deletions