diff options
| author | Pavel Begunkov <asml.silence@gmail.com> | 2022-05-13 11:24:56 +0100 |
|---|---|---|
| committer | Jens Axboe <axboe@kernel.dk> | 2022-05-13 06:50:42 -0600 |
| commit | e0deb6a025ae8c850dc8685be39fb27b06c88736 (patch) | |
| tree | f3f6e4af01512eefa04dc65d2d2d8f5f1e893693 /fs/io_uring.c | |
| parent | a8da73a32b6e9271a613e5a0e90a8c35f40abeb8 (diff) | |
io_uring: avoid io-wq -EAGAIN looping for !IOPOLL
If an opcode handler semi-reliably returns -EAGAIN, io_wq_submit_work()
might continue busily hammer the same handler over and over again, which
is not ideal. The -EAGAIN handling in question was put there only for
IOPOLL, so restrict it to IOPOLL mode only where there is no other
recourse than to retry as we cannot wait.
Fixes: def596e9557c9 ("io_uring: support for IO polling")
Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
Link: https://lore.kernel.org/r/f168b4f24181942f3614dd8ff648221736f572e6.1652433740.git.asml.silence@gmail.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'fs/io_uring.c')
| -rw-r--r-- | fs/io_uring.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/fs/io_uring.c b/fs/io_uring.c index 362189819898..f5f38329c823 100644 --- a/fs/io_uring.c +++ b/fs/io_uring.c @@ -7573,6 +7573,8 @@ fail: * wait for request slots on the block side. */ if (!needs_poll) { + if (!(req->ctx->flags & IORING_SETUP_IOPOLL)) + break; cond_resched(); continue; } |