diff options
| author | Matthew Wilcox (Oracle) <willy@infradead.org> | 2022-02-22 09:27:42 -0500 |
|---|---|---|
| committer | Matthew Wilcox (Oracle) <willy@infradead.org> | 2022-05-08 14:28:18 -0400 |
| commit | a125d2aec37c660afdd81d09dea616ef5d06eef4 (patch) | |
| tree | 5cf2e14f6a1727d83f461f1484abdac1fe7ed073 /fs/ext4 | |
| parent | 5fb9bfe01c88788ca3a99c44e44d52abb138595d (diff) | |
ext4: Use page_symlink() instead of __page_symlink()
By using the memalloc_nofs_save() functionality, we can call
page_symlink(), safe in the knowledge that it won't recurse into the
filesystem.
Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Diffstat (limited to 'fs/ext4')
| -rw-r--r-- | fs/ext4/namei.c | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c index 767b4bfe39c3..1e7c5deed5e3 100644 --- a/fs/ext4/namei.c +++ b/fs/ext4/namei.c @@ -29,6 +29,7 @@ #include <linux/pagemap.h> #include <linux/time.h> #include <linux/fcntl.h> +#include <linux/sched/mm.h> #include <linux/stat.h> #include <linux/string.h> #include <linux/quotaops.h> @@ -3308,6 +3309,8 @@ static int ext4_symlink(struct user_namespace *mnt_userns, struct inode *dir, } if ((disk_link.len > EXT4_N_BLOCKS * 4)) { + unsigned int flags; + if (!IS_ENCRYPTED(inode)) inode->i_op = &ext4_symlink_inode_operations; inode_nohighmem(inode); @@ -3329,7 +3332,9 @@ static int ext4_symlink(struct user_namespace *mnt_userns, struct inode *dir, handle = NULL; if (err) goto err_drop_inode; - err = __page_symlink(inode, disk_link.name, disk_link.len, 1); + flags = memalloc_nofs_save(); + err = page_symlink(inode, disk_link.name, disk_link.len); + memalloc_nofs_restore(flags); if (err) goto err_drop_inode; /* |