diff options
| author | Paulo Alcantara <pc@cjr.nz> | 2023-01-10 20:35:46 -0300 |
|---|---|---|
| committer | Steve French <stfrench@microsoft.com> | 2023-01-10 23:24:37 -0600 |
| commit | 2fe58d977ee05da5bb89ef5dc4f5bf2dc15db46f (patch) | |
| tree | 762d57d17801fac74445c5a8a19915d3898fdc5d /fs/cifs/sess.c | |
| parent | 22aeb01db7080e18c6aeb4361cc2556c9887099a (diff) | |
cifs: fix potential memory leaks in session setup
Make sure to free cifs_ses::auth_key.response before allocating it as
we might end up leaking memory in reconnect or mounting.
Signed-off-by: Paulo Alcantara (SUSE) <pc@cjr.nz>
Signed-off-by: Steve French <stfrench@microsoft.com>
Diffstat (limited to 'fs/cifs/sess.c')
| -rw-r--r-- | fs/cifs/sess.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/fs/cifs/sess.c b/fs/cifs/sess.c index 0b842a07e157..c47b254f0d1e 100644 --- a/fs/cifs/sess.c +++ b/fs/cifs/sess.c @@ -815,6 +815,7 @@ int decode_ntlmssp_challenge(char *bcc_ptr, int blob_len, return -EINVAL; } if (tilen) { + kfree_sensitive(ses->auth_key.response); ses->auth_key.response = kmemdup(bcc_ptr + tioffset, tilen, GFP_KERNEL); if (!ses->auth_key.response) { @@ -1428,6 +1429,7 @@ sess_auth_kerberos(struct sess_data *sess_data) goto out_put_spnego_key; } + kfree_sensitive(ses->auth_key.response); ses->auth_key.response = kmemdup(msg->data, msg->sesskey_len, GFP_KERNEL); if (!ses->auth_key.response) { |