diff options
author | Xiaomeng Tong <xiam0nd.tong@gmail.com> | 2022-03-27 14:22:02 +0800 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2022-04-24 17:24:23 +0200 |
commit | 5ac11fe03a0a83042d1a040dbce4fa2fb5521e23 (patch) | |
tree | f179414d05b5e03b835f2c923ab860777785ab1c /drivers/w1 | |
parent | 4834f9898c7301a365acd02095793d55b519e5a8 (diff) |
misc: fastrpc: fix an incorrect NULL check on list iterator
The bug is here:
if (!buf) {
The list iterator value 'buf' will *always* be set and non-NULL
by list_for_each_entry(), so it is incorrect to assume that the
iterator value will be NULL if the list is empty (in this case, the
check 'if (!buf) {' will always be false and never exit expectly).
To fix the bug, use a new variable 'iter' as the list iterator,
while use the original variable 'buf' as a dedicated pointer to
point to the found element.
Fixes: 2419e55e532de ("misc: fastrpc: add mmap/unmap support")
Signed-off-by: Xiaomeng Tong <xiam0nd.tong@gmail.com>
Link: https://lore.kernel.org/r/20220327062202.5720-1-xiam0nd.tong@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/w1')
0 files changed, 0 insertions, 0 deletions