summaryrefslogtreecommitdiff
path: root/drivers/video/fbdev/sm501fb.c
diff options
context:
space:
mode:
authorBartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>2019-06-28 12:30:08 +0200
committerBartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>2019-06-28 12:30:08 +0200
commit0adcdbcb179624d7b3677264f2cd228e7d89eea9 (patch)
tree72c9a50d59fec3ebfb463604efcb17c198b831de /drivers/video/fbdev/sm501fb.c
parent5f0e6ce18e65c463c52d00997397967ea809688b (diff)
video: fbdev: don't print error message on framebuffer_alloc() failure
framebuffer_alloc() can fail only on kzalloc() memory allocation failure and since kzalloc() will print error message in such case we can omit printing extra error message in drivers (which BTW is what the majority of framebuffer_alloc() users is doing already). Cc: "Bruno Prémont" <bonbons@linux-vserver.org> Cc: Jiri Kosina <jikos@kernel.org> Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Diffstat (limited to 'drivers/video/fbdev/sm501fb.c')
-rw-r--r--drivers/video/fbdev/sm501fb.c4
1 files changed, 1 insertions, 3 deletions
diff --git a/drivers/video/fbdev/sm501fb.c b/drivers/video/fbdev/sm501fb.c
index dde52d027416..285c5d6b733f 100644
--- a/drivers/video/fbdev/sm501fb.c
+++ b/drivers/video/fbdev/sm501fb.c
@@ -1868,10 +1868,8 @@ static int sm501fb_probe_one(struct sm501fb_info *info,
}
fbi = framebuffer_alloc(sizeof(struct sm501fb_par), info->dev);
- if (fbi == NULL) {
- dev_err(info->dev, "cannot allocate %s framebuffer\n", name);
+ if (!fbi)
return -ENOMEM;
- }
par = fbi->par;
par->info = info;