diff options
author | Stefan Hajnoczi <stefanha@redhat.com> | 2018-04-11 10:35:40 +0800 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2018-04-11 10:54:06 -0400 |
commit | d14d2b78090c7de0557362b26a4ca591aa6a9faa (patch) | |
tree | 94e3974bf7a5a5ea27d3cbc4c117792213ac6a3e /drivers/vhost/vhost.h | |
parent | 7ced6c98c7ab7a1f6743931e28671b833af79b1e (diff) |
vhost: fix vhost_vq_access_ok() log check
Commit d65026c6c62e7d9616c8ceb5a53b68bcdc050525 ("vhost: validate log
when IOTLB is enabled") introduced a regression. The logic was
originally:
if (vq->iotlb)
return 1;
return A && B;
After the patch the short-circuit logic for A was inverted:
if (A || vq->iotlb)
return A;
return B;
This patch fixes the regression by rewriting the checks in the obvious
way, no longer returning A when vq->iotlb is non-NULL (which is hard to
understand).
Reported-by: syzbot+65a84dde0214b0387ccd@syzkaller.appspotmail.com
Cc: Jason Wang <jasowang@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/vhost/vhost.h')
0 files changed, 0 insertions, 0 deletions