diff options
author | Greg Edwards <gedwards@ddn.com> | 2017-06-28 09:22:26 -0600 |
---|---|---|
committer | Jeff Kirsher <jeffrey.t.kirsher@intel.com> | 2017-08-08 17:52:45 -0700 |
commit | 46b3bb9b47ae63632892ad19976948b290aec2c6 (patch) | |
tree | 7caa76645a61ac0e449274318f733e9af84afb08 /drivers/vfio/virqfd.c | |
parent | 1a6c4a3b1e6f8fa1185457300514cd9f902de1a1 (diff) |
igb: do not drop PF mailbox lock after read of VF message
When the PF receives a mailbox message from the VF, it grabs the mailbox
lock, reads the VF message from the mailbox, ACKs the message and drops
the lock.
While the PF is performing the action for the VF message, nothing
prevents another VF message from being posted to the mailbox. The
current code handles this condition by just dropping any new VF messages
without processing them. This results in a mailbox timeout in the VM
for posted messages waiting for an ACK, and the VF is reset by the
igbvf_watchdog_task in the VM.
Given the right sequence of VF messages and mailbox timeouts, this
condition can go on ad infinitum.
Modify the PF mailbox read method to take an 'unlock' argument that
optionally leaves the mailbox locked by the PF after reading the VF
message. This ensures another VF message is not posted to the mailbox
until after the PF has completed processing the VF message and written
its reply.
Signed-off-by: Greg Edwards <gedwards@ddn.com>
Tested-by: Aaron Brown <aaron.f.brown@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Diffstat (limited to 'drivers/vfio/virqfd.c')
0 files changed, 0 insertions, 0 deletions