diff options
| author | Mark Rutland <mark.rutland@arm.com> | 2016-09-26 16:16:18 +0100 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2016-09-27 12:55:27 +0200 |
| commit | 9f12cea96f47f98d612a0a0b84f950a0163731bf (patch) | |
| tree | a3823338b982f0b751795f64ef09fc71bb93659a /drivers/tty | |
| parent | 4b75f80003617fe35771a9e27022e8fbd6a41875 (diff) | |
drivers/tty: Explicitly pass current to show_stack
As noted in commit:
81539169f283329f ("x86/dumpstack: Remove NULL task pointer convention")
... having a NULL task parameter imply current leads to subtle bugs in stack
walking code (so far seen on both 86 and arm64), makes callsites harder to
read, and is unnecessary as all callers have access to current.
As a step towards removing the problematic NULL-implies-current idiom entirely,
have the sysrq code explicitly pass current to show_stack.
Signed-off-by: Mark Rutland <mark.rutland@arm.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Jiri Slaby <jslaby@suse.com>
Cc: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/tty')
| -rw-r--r-- | drivers/tty/sysrq.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/tty/sysrq.c b/drivers/tty/sysrq.c index 52bbd27e93ae..5b1e0edacb84 100644 --- a/drivers/tty/sysrq.c +++ b/drivers/tty/sysrq.c @@ -224,7 +224,7 @@ static void showacpu(void *dummy) spin_lock_irqsave(&show_lock, flags); pr_info("CPU%d:\n", smp_processor_id()); - show_stack(NULL, NULL); + show_stack(current, NULL); spin_unlock_irqrestore(&show_lock, flags); } |