diff options
| author | Finn Thain <fthain@telegraphics.com.au> | 2014-11-12 16:11:52 +1100 |
|---|---|---|
| committer | Christoph Hellwig <hch@lst.de> | 2014-11-20 09:11:05 +0100 |
| commit | 4d3d2a54f731aa25f66adcf934ba9a55ca8204d4 (patch) | |
| tree | 99ddb1b68ec6d13a81550f07f4d877b1bea81df4 /drivers/scsi/pas16.c | |
| parent | ed8b9e7f1827ebae902e868866438d1bcdbef0a2 (diff) | |
ncr5380: Remove more useless prototypes
Make use of the host template static initializer instead of assigning
handlers at run-time. Move __maybe_unused qualifiers from declarations
to definitions. Move the atari_scsi_bus_reset() wrapper after the
definition of NCR5380_bus_reset(). All of the host template handler
prototypes are now redundant so remove them.
The write_info() handler is only relevant to drivers using PSEUDO_DMA so
this patch fixes the compiler warning in atari_NCR5380.c and sun3_NCR5380.c:
CC drivers/scsi/atari_scsi.o
drivers/scsi/NCR5380.h:329: warning: 'NCR5380_write_info' declared 'static' but never defined
Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
Tested-by: Michael Schmitz <schmitzmic@gmail.com>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Diffstat (limited to 'drivers/scsi/pas16.c')
| -rw-r--r-- | drivers/scsi/pas16.c | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/drivers/scsi/pas16.c b/drivers/scsi/pas16.c index 736540e789ed..ffa399e7860a 100644 --- a/drivers/scsi/pas16.c +++ b/drivers/scsi/pas16.c @@ -390,10 +390,6 @@ static int __init pas16_detect(struct scsi_host_template *tpnt) unsigned short io_port; int count; - tpnt->proc_name = "pas16"; - tpnt->show_info = pas16_show_info; - tpnt->write_info = pas16_write_info; - if (pas16_addr != 0) { overrides[0].io_port = pas16_addr; /* @@ -620,6 +616,9 @@ static struct scsi_host_template driver_template = { .name = "Pro Audio Spectrum-16 SCSI", .detect = pas16_detect, .release = pas16_release, + .proc_name = "pas16", + .show_info = pas16_show_info, + .write_info = pas16_write_info, .queuecommand = pas16_queue_command, .eh_abort_handler = pas16_abort, .eh_bus_reset_handler = pas16_bus_reset, |