diff options
| author | Fabio Estevam <festevam@gmail.com> | 2021-07-23 17:32:42 -0300 |
|---|---|---|
| committer | Linus Walleij <linus.walleij@linaro.org> | 2021-07-23 22:52:47 +0200 |
| commit | af0ca06f8781499bd889658b47df75ee2da8ca8f (patch) | |
| tree | 6df4cc7b5cfb5e48c216c2b035b3767f3b08a646 /drivers/pinctrl | |
| parent | 79e2311c876c276566e3fb84ba33682eb540874b (diff) | |
pinctrl: imx8ulp: Initialize pin_reg
The initialization of pin_reg is missing, causing the following build
warning:
drivers/pinctrl/freescale/pinctrl-imx8ulp.c:228:35: warning: 'pin_reg' is used uninitialized in this function [-Wuninitialized]
Initialize pin_reg the same way as it is done on vf610 and imx7ulp
to fix the problem.
Fixes: 16b343e8e0ef ("pinctrl: imx8ulp: Add pinctrl driver support")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Fabio Estevam <festevam@gmail.com>
Link: https://lore.kernel.org/r/20210723203242.88845-1-festevam@gmail.com
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Diffstat (limited to 'drivers/pinctrl')
| -rw-r--r-- | drivers/pinctrl/freescale/pinctrl-imx8ulp.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/drivers/pinctrl/freescale/pinctrl-imx8ulp.c b/drivers/pinctrl/freescale/pinctrl-imx8ulp.c index c5db5dfcfcce..f8572597a54e 100644 --- a/drivers/pinctrl/freescale/pinctrl-imx8ulp.c +++ b/drivers/pinctrl/freescale/pinctrl-imx8ulp.c @@ -225,6 +225,10 @@ static int imx8ulp_pmx_gpio_set_direction(struct pinctrl_dev *pctldev, const struct imx_pin_reg *pin_reg; u32 reg; + pin_reg = &ipctl->pin_regs[offset]; + if (pin_reg->mux_reg == -1) + return -EINVAL; + reg = readl(ipctl->base + pin_reg->mux_reg); if (input) reg = (reg & ~BM_OBE_ENABLED) | BM_IBE_ENABLED; |