diff options
| author | Breno Leitao <leitao@debian.org> | 2023-01-25 10:52:30 -0800 |
|---|---|---|
| committer | Jakub Kicinski <kuba@kernel.org> | 2023-01-27 23:24:07 -0800 |
| commit | d8afe2f8a92d2aac3df645772f6ee61b0b2fc147 (patch) | |
| tree | 68b29285bf927978c7019d7f2cd9d3331a437b3e /drivers/net/phy/sfp.c | |
| parent | b568d3072a443fac22d35d6342f48ee27b811661 (diff) | |
netpoll: Remove 4s sleep during carrier detection
This patch removes the msleep(4s) during netpoll_setup() if the carrier
appears instantly.
Here are some scenarios where this workaround is counter-productive in
modern ages:
Servers which have BMC communicating over NC-SI via the same NIC as gets
used for netconsole. BMC will keep the PHY up, hence the carrier
appearing instantly.
The link is fibre, SERDES getting sync could happen within 0.1Hz, and
the carrier also appears instantly.
Other than that, if a driver is reporting instant carrier and then
losing it, this is probably a driver bug.
Reported-by: Michael van der Westhuizen <rmikey@meta.com>
Signed-off-by: Breno Leitao <leitao@debian.org>
Link: https://lore.kernel.org/r/20230125185230.3574681-1-leitao@debian.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'drivers/net/phy/sfp.c')
0 files changed, 0 insertions, 0 deletions