diff options
author | Nikolay Aleksandrov <nikolay@redhat.com> | 2013-08-01 11:51:42 +0200 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2013-08-01 15:52:49 -0700 |
commit | 4beac0293fabb68125e1a9d2ce81d89343f8702d (patch) | |
tree | 9ebf458d36610e004303d36cd83ae5992354594e /drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c | |
parent | 9ab5ec59c8a9cc0e4b94252b48200b6023c716aa (diff) |
bonding: fix system hang due to fast igmp timer rescheduling
After commit 4aa5dee4d9 ("net: convert resend IGMP to notifier event")
we try to acquire rtnl in bond_resend_igmp_join_requests but it can be
scheduled with rtnl already held (e.g. when bond_change_active_slave is
called with rtnl) causing a loop of immediate reschedules + calls because
rtnl_trylock fails each time since it's being already held.
For me this issue leads to system hangs very easy:
modprobe bonding; ifconfig bond0 up; ifenslave bond0 eth0; rmmod
bonding;
The fix is to introduce a small (1 jiffy) delay which is enough for the
sections holding rtnl to finish without putting any strain on the system.
Also adjust the timer in bond_change_active_slave to be 1 jiffy, since
most of the time it's called with rtnl already held.
Signed-off-by: Nikolay Aleksandrov <nikolay@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c')
0 files changed, 0 insertions, 0 deletions