diff options
| author | Uwe Kleine-König <u.kleine-koenig@pengutronix.de> | 2022-05-04 20:31:31 +0200 |
|---|---|---|
| committer | Pavel Machek <pavel@ucw.cz> | 2022-05-07 23:10:22 +0200 |
| commit | e1347bd4abfb3eaee8bbdc9089b64b249a7639b6 (patch) | |
| tree | 6a57f915cca6bdd4b87e49194601fb9fa4add5a6 /drivers/leds | |
| parent | 818d03b3d4ae00eeb56687d2115a930406b2c7b3 (diff) | |
leds: is31fl32xx: Improve error reporting in .remove()
Returning an error value in an i2c remove callback results in a generic
error message being emitted by the i2c core, but otherwise it doesn't make
a difference. The device goes away anyhow and the devm cleanups are
called.
So instead of triggering the generic i2c error message, emit a more helpful
message if a problem occurs and return 0 to suppress the generic message.
This patch is a preparation for making i2c remove callbacks return void.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Pavel Machek <pavel@ucw.cz>
Diffstat (limited to 'drivers/leds')
| -rw-r--r-- | drivers/leds/leds-is31fl32xx.c | 8 |
1 files changed, 7 insertions, 1 deletions
diff --git a/drivers/leds/leds-is31fl32xx.c b/drivers/leds/leds-is31fl32xx.c index 22c092a4394a..fc63fce38c19 100644 --- a/drivers/leds/leds-is31fl32xx.c +++ b/drivers/leds/leds-is31fl32xx.c @@ -460,8 +460,14 @@ static int is31fl32xx_probe(struct i2c_client *client, static int is31fl32xx_remove(struct i2c_client *client) { struct is31fl32xx_priv *priv = i2c_get_clientdata(client); + int ret; - return is31fl32xx_reset_regs(priv); + ret = is31fl32xx_reset_regs(priv); + if (ret) + dev_err(&client->dev, "Failed to reset registers on removal (%pe)\n", + ERR_PTR(ret)); + + return 0; } /* |