diff options
| author | Xu Wang <vulab@iscas.ac.cn> | 2019-12-27 09:34:32 +0000 |
|---|---|---|
| committer | Wolfram Sang <wsa@kernel.org> | 2022-06-16 21:39:40 +0200 |
| commit | e4c72c06c367758a14f227c847f9d623f1994ecf (patch) | |
| tree | bea84d2a77eb97f4a861e6e9e3a31babdac91a02 /drivers/i2c | |
| parent | 4dc1372ffb82c5f08ada7b9cb75a04dcfe49cd96 (diff) | |
i2c: Fix a potential use after free
Free the adap structure only after we are done using it.
This patch just moves the put_device() down a bit to avoid the
use after free.
Fixes: 611e12ea0f12 ("i2c: core: manage i2c bus device refcount in i2c_[get|put]_adapter")
Signed-off-by: Xu Wang <vulab@iscas.ac.cn>
[wsa: added comment to the code, added Fixes tag]
Signed-off-by: Wolfram Sang <wsa@kernel.org>
Diffstat (limited to 'drivers/i2c')
| -rw-r--r-- | drivers/i2c/i2c-core-base.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/i2c/i2c-core-base.c b/drivers/i2c/i2c-core-base.c index 8ae47e0bbd67..10f35f942066 100644 --- a/drivers/i2c/i2c-core-base.c +++ b/drivers/i2c/i2c-core-base.c @@ -2461,8 +2461,9 @@ void i2c_put_adapter(struct i2c_adapter *adap) if (!adap) return; - put_device(&adap->dev); module_put(adap->owner); + /* Should be last, otherwise we risk use-after-free with 'adap' */ + put_device(&adap->dev); } EXPORT_SYMBOL(i2c_put_adapter); |