diff options
| author | Allen Hubbe <Allen.Hubbe@emc.com> | 2015-08-11 04:05:42 -0400 |
|---|---|---|
| committer | Vinod Koul <vinod.koul@intel.com> | 2015-08-17 13:35:58 +0530 |
| commit | 870ce49022d1a278e441d2cb7b92acae2416b510 (patch) | |
| tree | a8f8a6c2700ab22fd3962496ac8ec6a14a8ef364 /drivers/dma | |
| parent | 3d8cc00073d6750ffe883685e49b2e4a0f596370 (diff) | |
dmaengine: ioatdma: fix u16 overflow in reshape
If the allocation order is 16, then the u16 index will overflow and wrap
to zero instead of being equal or greater than 1 << 16. The loop
condition will always be true, and the loop will run until all the
memory resources are depleted.
Change the type of index 'i' to u32, so that it is large enough to store
a value equal or greater than 1 << 16.
Signed-off-by: Allen Hubbe <Allen.Hubbe@emc.com>
Acked-by: Dave Jiang <dave.jiang@intel.com>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
Diffstat (limited to 'drivers/dma')
| -rw-r--r-- | drivers/dma/ioat/dma_v2.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/dma/ioat/dma_v2.c b/drivers/dma/ioat/dma_v2.c index 69c7dfcad023..13fbd9d5b5b9 100644 --- a/drivers/dma/ioat/dma_v2.c +++ b/drivers/dma/ioat/dma_v2.c @@ -588,7 +588,7 @@ bool reshape_ring(struct ioat2_dma_chan *ioat, int order) const u16 active = ioat2_ring_active(ioat); const u32 new_size = 1 << order; struct ioat_ring_ent **ring; - u16 i; + u32 i; if (order > ioat_get_max_alloc_order()) return false; |