diff options
| author | Jia-Ju Bai <baijiaju1990@gmail.com> | 2018-01-25 18:26:52 +0800 |
|---|---|---|
| committer | Tejun Heo <tj@kernel.org> | 2018-01-25 07:28:13 -0800 |
| commit | e72685dbd2e7782ce99ccd198e52dc0d9cf1d16f (patch) | |
| tree | cd44a339302a206e1f0aa4c723af2c3a7a35217c /drivers/ata/sata_mv.c | |
| parent | 6590425218b9e8cedf6acd3dd903fb7a907937b7 (diff) | |
ata: sata_mv: Replace mdelay with usleep_range in mv_reset_channel
After checking all possible call chains to mv_reset_channel here,
my tool finds that mv_reset_channel is never called in atomic context,
namely never in an interrupt handler or holding a spinlock.
Thus mdelay can be replaced with usleep_range to avoid busy wait.
This is found by a static analysis tool named DCNS written by myself.
Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
Diffstat (limited to 'drivers/ata/sata_mv.c')
| -rw-r--r-- | drivers/ata/sata_mv.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/ata/sata_mv.c b/drivers/ata/sata_mv.c index cc208b72b199..42d4589b43d4 100644 --- a/drivers/ata/sata_mv.c +++ b/drivers/ata/sata_mv.c @@ -3596,7 +3596,7 @@ static void mv_reset_channel(struct mv_host_priv *hpriv, void __iomem *mmio, hpriv->ops->phy_errata(hpriv, mmio, port_no); if (IS_GEN_I(hpriv)) - mdelay(1); + usleep_range(500, 1000); } static void mv_pmp_select(struct ata_port *ap, int pmp) |