diff options
author | Tejun Heo <tj@kernel.org> | 2019-08-02 12:08:13 -0700 |
---|---|---|
committer | Jens Axboe <axboe@kernel.dk> | 2019-08-15 13:30:46 -0600 |
commit | 6444f47eb8678a43d5260c67b89c18b1ea09e79e (patch) | |
tree | 8ad4e7d6831c77414208f33e5dfeb729ab5dcc4c /block | |
parent | 55a694dffb7fd126b1e047aa46c437731d2700bb (diff) |
writeback, cgroup: inode_switch_wbs() shouldn't give up on wb_switch_rwsem trylock fail
As inode wb switching may make sync(2) miss some inodes, they're
synchronized using wb_switch_rwsem so that no wb switching happens
while sync(2) is in progress. In addition to synchronizing the actual
switching, the rwsem is also used to prevent queueing new switch
attempts while sync(2) is in progress. This is to avoid queueing too
many instances while the rwsem is held by sync(2). Unfortunately,
this is too agressive and can block wb switching for a long time if
sync(2) is frequent.
The goal is avoiding expolding the number of scheduled switches, not
avoiding scheduling anything. Let's use wb_switch_rwsem only for
synchronizing the actual switching and sync(2) and use
isw_nr_in_flight instead for limiting the maximum number of scheduled
switches. The limit is set to 1024 which should be more than enough
while still avoiding extreme situations.
Reviewed-by: Jan Kara <jack@suse.cz>
Signed-off-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'block')
0 files changed, 0 insertions, 0 deletions