diff options
author | Al Viro <viro@zeniv.linux.org.uk> | 2018-05-02 21:26:16 -0400 |
---|---|---|
committer | Al Viro <viro@zeniv.linux.org.uk> | 2018-05-22 14:28:03 -0400 |
commit | 1bbc55131e59bd099fdc568d3aa0b42634dbd188 (patch) | |
tree | 42f965fe9a163a3bdaf8d8a51a6649afbf7118ce /LICENSES | |
parent | 11f17c9bd77baf341351d09b6881cd6ff92b5dd4 (diff) |
procfs: get rid of ancient BS in pid_revalidate() uses
First of all, calling pid_revalidate() in the end of <pid>/* lookups
is *not* about closing any kind of races; that used to be true once
upon a time, but these days those comments are actively misleading.
Especially since pid_revalidate() doesn't even do d_drop() on
failure anymore. It doesn't matter, anyway, since once
pid_revalidate() starts returning false, ->d_delete() of those
dentries starts saying "don't keep"; they won't get stuck in
dcache any longer than they are pinned.
These calls cannot be just removed, though - the side effect of
pid_revalidate() (updating i_uid/i_gid/etc.) is what we are calling
it for here.
Let's separate the "update ownership" into a new helper (pid_update_inode())
and use it, both in lookups and in pid_revalidate() itself.
The comments in pid_revalidate() are also out of date - they refer to
the time when pid_revalidate() used to call d_drop() directly...
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'LICENSES')
0 files changed, 0 insertions, 0 deletions