diff options
author | Moshe Shemesh <moshe@nvidia.com> | 2023-10-05 15:50:16 +0300 |
---|---|---|
committer | Jakub Kicinski <kuba@kernel.org> | 2023-10-06 15:56:46 -0700 |
commit | aba0e909dc20eceb1de985474af459f82e7b0b82 (patch) | |
tree | abc4cd4704db73c3d8702c7025f6851ca28fef6c /CREDITS | |
parent | c4d49196ceec80e30e8d981410d73331b49b7850 (diff) |
devlink: Hold devlink lock on health reporter dump get
Devlink health dump get callback should take devlink lock as any other
devlink callback. Otherwise, since devlink_mutex was removed, this
callback is not protected from a race of the reporter being destroyed
while handling the callback.
Add devlink lock to the callback and to any call for
devlink_health_do_dump(). This should be safe as non of the drivers dump
callback implementation takes devlink lock.
As devlink lock is added to any callback of dump, the reporter dump_lock
is now redundant and can be removed.
Fixes: d3efc2a6a6d8 ("net: devlink: remove devlink_mutex")
Signed-off-by: Moshe Shemesh <moshe@nvidia.com>
Reviewed-by: Jiri Pirko <jiri@nvidia.com>
Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
Link: https://lore.kernel.org/r/1696510216-189379-1-git-send-email-moshe@nvidia.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'CREDITS')
0 files changed, 0 insertions, 0 deletions