diff options
| author | Taehee Yoo <ap420073@gmail.com> | 2021-11-16 16:09:23 +0000 |
|---|---|---|
| committer | Jakub Kicinski <kuba@kernel.org> | 2021-11-16 19:14:12 -0800 |
| commit | b0024a04e48837b6556a080ff37ecd8351632596 (patch) | |
| tree | cdb8ffc63102c55e4030e73d5da976e61a50a159 | |
| parent | 0a83f96f8709f65a6498a012ba49f608925dfae6 (diff) | |
amt: cancel delayed_work synchronously in amt_fini()
When the amt module is being removed, it calls cancel_delayed_work()
to cancel pending delayed_work. But this function doesn't wait for
canceling delayed_work.
So, workers can be still doing after module delete.
In order to avoid this, cancel_delayed_work_sync() should be used instead.
Suggested-by: Jakub Kicinski <kuba@kernel.org>
Fixes: bc54e49c140b ("amt: add multicast(IGMP) report message handler")
Signed-off-by: Taehee Yoo <ap420073@gmail.com>
Link: https://lore.kernel.org/r/20211116160923.25258-1-ap420073@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
| -rw-r--r-- | drivers/net/amt.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/amt.c b/drivers/net/amt.c index 47a04c330885..b732ee9a50ef 100644 --- a/drivers/net/amt.c +++ b/drivers/net/amt.c @@ -3286,7 +3286,7 @@ static void __exit amt_fini(void) { rtnl_link_unregister(&amt_link_ops); unregister_netdevice_notifier(&amt_notifier_block); - cancel_delayed_work(&source_gc_wq); + cancel_delayed_work_sync(&source_gc_wq); __amt_source_gc_work(); destroy_workqueue(amt_wq); } |