summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorYang Li <yang.lee@linux.alibaba.com>2021-06-07 13:56:20 +0800
committerJon Mason <jdmason@kudzu.us>2021-09-04 18:36:04 -0400
commit319f83ac98d7afaabab84ce5281a819a358b9895 (patch)
tree9a7d19dc0c9d65010f0a21f3dfa7f26bb02dc2ce
parentf3b6b10fccc44ce0343878a1ed7cd8ef8fd687d8 (diff)
NTB: Fix an error code in ntb_msit_probe()
When the value of nm->isr_ctx is false, the value of ret is 0. So, we set ret to -ENOMEM to indicate this error. Clean up smatch warning: drivers/ntb/test/ntb_msi_test.c:373 ntb_msit_probe() warn: missing error code 'ret'. Reported-by: Abaci Robot <abaci@linux.alibaba.com> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> Reviewed-by: Logan Gunthorpe <logang@deltatee.com> Signed-off-by: Jon Mason <jdmason@kudzu.us>
-rw-r--r--drivers/ntb/test/ntb_msi_test.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/ntb/test/ntb_msi_test.c b/drivers/ntb/test/ntb_msi_test.c
index 7095ecd6223a..4e18e08776c9 100644
--- a/drivers/ntb/test/ntb_msi_test.c
+++ b/drivers/ntb/test/ntb_msi_test.c
@@ -369,8 +369,10 @@ static int ntb_msit_probe(struct ntb_client *client, struct ntb_dev *ntb)
if (ret)
goto remove_dbgfs;
- if (!nm->isr_ctx)
+ if (!nm->isr_ctx) {
+ ret = -ENOMEM;
goto remove_dbgfs;
+ }
ntb_link_enable(ntb, NTB_SPEED_AUTO, NTB_WIDTH_AUTO);