summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorBob Peterson <rpeterso@redhat.com>2023-04-21 15:07:09 -0400
committerAndreas Gruenbacher <agruenba@redhat.com>2023-04-25 11:06:30 +0200
commitb97e583caa25abf95695cd06d7f9512b484c6c01 (patch)
tree6031d8b2f3097b508d0bee8526be15b9e74931b5
parent68ca088dc1cfc4e366811b11ffe2954c6dcebca1 (diff)
gfs2: Issue message when revokes cannot be written
Before this patch, function gfs2_ail_empty_gl would silently return an error to the caller. This would get silently set into sd_log_error which would cause a withdraw, but there was no indication why the file system was withdrawn. This patch adds a fs_err to log the appropriate error message. Signed-off-by: Bob Peterson <rpeterso@redhat.com> Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
-rw-r--r--fs/gfs2/glops.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/fs/gfs2/glops.c b/fs/gfs2/glops.c
index 29e0a664efd6..caef70334af3 100644
--- a/fs/gfs2/glops.c
+++ b/fs/gfs2/glops.c
@@ -124,8 +124,10 @@ static int gfs2_ail_empty_gl(struct gfs2_glock *gl)
memset(&tr, 0, sizeof(tr));
set_bit(TR_ONSTACK, &tr.tr_flags);
ret = __gfs2_trans_begin(&tr, sdp, 0, revokes, _RET_IP_);
- if (ret)
+ if (ret) {
+ fs_err(sdp, "Transaction error %d: Unable to write revokes.", ret);
goto flush;
+ }
__gfs2_ail_flush(gl, 0, revokes);
gfs2_trans_end(sdp);