summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorGao Xiang <hsiangkao@redhat.com>2020-09-19 15:27:28 +0800
committerGao Xiang <hsiangkao@redhat.com>2020-09-19 15:35:17 +0800
commit6c3e485ea37da2bcca68e6b8c635ddd2b4da540d (patch)
tree8a74afedbec2d685b48a8cda56b16e4410deb760
parente3f78d5e7e6b0825f4e646f74b0e469b023e5df4 (diff)
erofs: avoid unnecessary variable `err'
variable `err' in z_erofs_submit_queue() isn't useful here, remove it instead. Reviewed-by: Chao Yu <yuchao0@huawei.com> Link: https://lore.kernel.org/r/20200919072730.24989-1-hsiangkao@redhat.com Signed-off-by: Gao Xiang <hsiangkao@redhat.com>
-rw-r--r--fs/erofs/zdata.c4
1 files changed, 1 insertions, 3 deletions
diff --git a/fs/erofs/zdata.c b/fs/erofs/zdata.c
index ac6cb73df192..e43684b23fdd 100644
--- a/fs/erofs/zdata.c
+++ b/fs/erofs/zdata.c
@@ -1190,7 +1190,6 @@ static void z_erofs_submit_queue(struct super_block *sb,
do {
struct page *page;
- int err;
page = pickup_page_for_submission(pcl, i++, pagepool,
MNGD_MAPPING(sbi),
@@ -1216,8 +1215,7 @@ submit_bio_retry:
++nr_bios;
}
- err = bio_add_page(bio, page, PAGE_SIZE, 0);
- if (err < PAGE_SIZE)
+ if (bio_add_page(bio, page, PAGE_SIZE, 0) < PAGE_SIZE)
goto submit_bio_retry;
last_index = cur;