diff options
| author | Linus Torvalds <torvalds@linux-foundation.org> | 2018-10-27 11:03:27 -0700 |
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2018-10-27 11:03:27 -0700 |
| commit | 69d5b97c597307773fe6c59775a5d5a88bb7e6b3 (patch) | |
| tree | d660625dd0b02721835be2db7a88137989a36339 | |
| parent | 5ecf3e110c32c5756351eed067cdf6a91c308e62 (diff) | |
HID: we do not randomly make new drivers 'default y'
.. even when that "default y" is hidden syntactically as a
default !EXPERT
it's wrong.
The only reason something should be 'default y' is if it used to be
built-in, and it was made configurable, and the 'default y' is just
retaining the status quo.
Altheratively, the hardware for the driver has become _so_ common that
it really makes sense for everybody to build it. Finally, one possible
reason for 'default y' is because the option is not enabling any new
code at all, but is just enabling other options (the networking people
do this for vendor options, for example, so that you can disable whole
vendors at a time).
Clearly, none of these cases hold for the BigBen Interactive Kids'
gamepad, and HID_BIGBEN_FF should thus most definitely not default
to on for everybody.
Cc: Hanno Zulla <kontakt@hanno.de>
Cc: Jiri Kosina <jkosina@suse.cz>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
| -rw-r--r-- | drivers/hid/Kconfig | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig index 18c846477ba2..5ed319e3b084 100644 --- a/drivers/hid/Kconfig +++ b/drivers/hid/Kconfig @@ -188,7 +188,6 @@ config HID_BIGBEN_FF depends on NEW_LEDS depends on LEDS_CLASS select INPUT_FF_MEMLESS - default !EXPERT help Support for the "Kid-friendly Wired Controller" PS3OFMINIPAD gamepad made by BigBen Interactive, originally sold as a PS3 |