diff options
| author | zhong jiang <zhongjiang@huawei.com> | 2019-09-05 12:25:37 +0800 |
|---|---|---|
| committer | Johannes Berg <johannes.berg@intel.com> | 2019-09-11 09:33:29 +0200 |
| commit | 24f6d765c8926ef32b88db8abab4188f23094d46 (patch) | |
| tree | ac9c8f856b91b78b0bb816b218cfbf6431e49850 | |
| parent | 4b08d1b6a994dbb593557bd2095ba4f0c3c47819 (diff) | |
cfg80211: Do not compare with boolean in nl80211_common_reg_change_event
With the help of boolinit.cocci, we use !nl80211_reg_change_event_fill
instead of (nl80211_reg_change_event_fill == false). Meanwhile, Clean
up the code.
Signed-off-by: zhong jiang <zhongjiang@huawei.com>
Link: https://lore.kernel.org/r/1567657537-65472-1-git-send-email-zhongjiang@huawei.com
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
| -rw-r--r-- | net/wireless/nl80211.c | 8 |
1 files changed, 3 insertions, 5 deletions
diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c index 3e30e18d1d89..0c7fa6004ffb 100644 --- a/net/wireless/nl80211.c +++ b/net/wireless/nl80211.c @@ -14997,12 +14997,10 @@ void nl80211_common_reg_change_event(enum nl80211_commands cmd_id, return; hdr = nl80211hdr_put(msg, 0, 0, 0, cmd_id); - if (!hdr) { - nlmsg_free(msg); - return; - } + if (!hdr) + goto nla_put_failure; - if (nl80211_reg_change_event_fill(msg, request) == false) + if (!nl80211_reg_change_event_fill(msg, request)) goto nla_put_failure; genlmsg_end(msg, hdr); |