diff options
| author | Su Yue <suy.fnst@cn.fujitsu.com> | 2018-11-28 11:21:12 +0800 |
|---|---|---|
| committer | David Sterba <dsterba@suse.com> | 2019-07-01 13:34:55 +0200 |
| commit | 8f63a84051e8e42aa99291197e4adae67241a705 (patch) | |
| tree | 737bd32cbd92ee045380bdee5ad4a8e5d917cb8b | |
| parent | 4c094c33c9ed4b8d0d814bd1d7ff78e123d15d00 (diff) | |
btrfs: switch order of unlocks of space_info and bg in do_trimming()
In function do_trimming(), block_group->lock should be unlocked first,
as the locks should be released in the reverse order. This does not
cause problems but should follow the best practices.
Reviewed-by: Nikolay Borisov <nborisov@suse.com>
Signed-off-by: Su Yue <suy.fnst@cn.fujitsu.com>
Reviewed-by: David Sterba <dsterba@suse.com>
[ update changelog ]
Signed-off-by: David Sterba <dsterba@suse.com>
| -rw-r--r-- | fs/btrfs/free-space-cache.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/btrfs/free-space-cache.c b/fs/btrfs/free-space-cache.c index f74dc259307b..9a76e7671938 100644 --- a/fs/btrfs/free-space-cache.c +++ b/fs/btrfs/free-space-cache.c @@ -3166,8 +3166,8 @@ static int do_trimming(struct btrfs_block_group_cache *block_group, space_info->bytes_readonly += reserved_bytes; block_group->reserved -= reserved_bytes; space_info->bytes_reserved -= reserved_bytes; - spin_unlock(&space_info->lock); spin_unlock(&block_group->lock); + spin_unlock(&space_info->lock); } return ret; |