summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTony Lindgren <tony@atomide.com>2017-06-12 01:12:23 -0700
committerKishon Vijay Abraham I <kishon@ti.com>2017-06-16 11:40:21 +0530
commit259a24001a501c09e7c6b718aed3b1b58641534b (patch)
treed67eb7310f24228518472e7efdb917e695521ec2
parent787f24543c4a599e5d9d311a3fce839ce87bbff0 (diff)
phy: cpcap-usb: Fix missing return statement
Commit 8ae904e3c236 ("phy: cpcap-usb: Add CPCAP PMIC USB support") is missing return statement as noted by Colin Ian King <colin.king@canonical.com>. If the optional pins are not configured, we just want to return early and not attempt to configure the pins. Fixes: 8ae904e3c236 ("phy: cpcap-usb: Add CPCAP PMIC USB support") Reported-by: Colin Ian King <colin.king@canonical.com> Signed-off-by: Tony Lindgren <tony@atomide.com> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
-rw-r--r--drivers/phy/motorola/phy-cpcap-usb.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/phy/motorola/phy-cpcap-usb.c b/drivers/phy/motorola/phy-cpcap-usb.c
index 082a48bd4d89..9b63efa5ae4d 100644
--- a/drivers/phy/motorola/phy-cpcap-usb.c
+++ b/drivers/phy/motorola/phy-cpcap-usb.c
@@ -468,6 +468,8 @@ static int cpcap_usb_init_optional_pins(struct cpcap_phy_ddata *ddata)
dev_info(ddata->dev, "default pins not configured: %ld\n",
PTR_ERR(ddata->pins));
ddata->pins = NULL;
+
+ return 0;
}
ddata->pins_ulpi = pinctrl_lookup_state(ddata->pins, "ulpi");