diff options
| author | Yang Yingliang <yangyingliang@huawei.com> | 2022-11-15 17:15:08 +0800 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2022-11-15 10:36:15 +0000 |
| commit | f2b41b748c19962b82709d9f23c6b2b0ce9d2f91 (patch) | |
| tree | 3f29d7edd99d799cf030c2ab8d04c86a7f98f812 | |
| parent | 91016037216b3aaa0fa1b616d388053fb4202835 (diff) | |
regulator: core: fix unbalanced of node refcount in regulator_dev_lookup()
I got the the following report:
OF: ERROR: memory leak, expected refcount 1 instead of 2,
of_node_get()/of_node_put() unbalanced - destroy cset entry:
attach overlay node /i2c/pmic@62/regulators/exten
In of_get_regulator(), the node is returned from of_parse_phandle()
with refcount incremented, after using it, of_node_put() need be called.
Fixes: 69511a452e6d ("regulator: map consumer regulator based on device tree")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Link: https://lore.kernel.org/r/20221115091508.900752-1-yangyingliang@huawei.com
Signed-off-by: Mark Brown <broonie@kernel.org>
| -rw-r--r-- | drivers/regulator/core.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c index 704f91720dfe..3f6c6185c187 100644 --- a/drivers/regulator/core.c +++ b/drivers/regulator/core.c @@ -1943,6 +1943,7 @@ static struct regulator_dev *regulator_dev_lookup(struct device *dev, node = of_get_regulator(dev, supply); if (node) { r = of_find_regulator_by_node(node); + of_node_put(node); if (r) return r; |