diff options
| author | Dan Carpenter <dan.carpenter@linaro.org> | 2024-05-10 18:22:53 +0300 |
|---|---|---|
| committer | Theodore Ts'o <tytso@mit.edu> | 2024-05-17 11:24:38 -0400 |
| commit | c6a6c9694aadc4c3ab8d89bdd44aed3eab1e43c6 (patch) | |
| tree | 2c08720e119b6c4b1f4983750a1fb819f098fa49 | |
| parent | 26770a717cac57041d9414725e3e01dd19b08dd2 (diff) | |
ext4: fix error pointer dereference in ext4_mb_load_buddy_gfp()
This code calls folio_put() on an error pointer which will lead to a
crash. Check for both error pointers and NULL pointers before calling
folio_put().
Fixes: 5eea586b47f0 ("ext4: convert bd_buddy_page to bd_buddy_folio")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://lore.kernel.org/r/eaafa1d9-a61c-4af4-9f97-d3ad72c60200@moroto.mountain
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
| -rw-r--r-- | fs/ext4/mballoc.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c index 648989c125f2..9dda9cd68ab2 100644 --- a/fs/ext4/mballoc.c +++ b/fs/ext4/mballoc.c @@ -1717,7 +1717,7 @@ ext4_mb_load_buddy_gfp(struct super_block *sb, ext4_group_t group, return 0; err: - if (folio) + if (!IS_ERR_OR_NULL(folio)) folio_put(folio); if (e4b->bd_bitmap_folio) folio_put(e4b->bd_bitmap_folio); |