diff options
| author | Boaz Harrosh <bharrosh@panasas.com> | 2011-02-07 18:12:15 +0200 |
|---|---|---|
| committer | Boaz Harrosh <bharrosh@panasas.com> | 2011-03-15 15:02:52 +0200 |
| commit | a49fb4c3d035ab516507b31ec3bd49263caee14d (patch) | |
| tree | aa44d448190dacad75b30fe86c49a72ad9cecc0d | |
| parent | 1cea312ad49d9cb964179a784fedb1fcfe396283 (diff) | |
exofs: deprecate the commands pending counter
One leftover from the days of IBM's original code, is an SB counter
that counts in-flight asynchronous commands. And a piece of code that
waits for the counter to reach zero at unmount. I guess it might have
been needed then, cause of some reference missing or something.
I'm not removing it yet but am putting a warning message if ever this
counter triggers at unmount. If I'll never see it triggers or reported
I'll remove the counter for good.
(I had this print as a debug output for a long time and never had it
trigger)
Signed-off-by: Boaz Harrosh <bharrosh@panasas.com>
| -rw-r--r-- | fs/exofs/super.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/fs/exofs/super.c b/fs/exofs/super.c index 5eb0851e5481..06065bd37fc3 100644 --- a/fs/exofs/super.c +++ b/fs/exofs/super.c @@ -409,6 +409,10 @@ static void exofs_put_super(struct super_block *sb) for (num_pend = atomic_read(&sbi->s_curr_pending); num_pend > 0; num_pend = atomic_read(&sbi->s_curr_pending)) { wait_queue_head_t wq; + + printk(KERN_NOTICE "%s: !!Pending operations in flight. " + "This is a BUG. please report to osd-dev@open-osd.org\n", + __func__); init_waitqueue_head(&wq); wait_event_timeout(wq, (atomic_read(&sbi->s_curr_pending) == 0), |