diff options
| author | Richard Fitzgerald <rf@opensource.cirrus.com> | 2023-12-18 15:17:29 +0000 |
|---|---|---|
| committer | Shuah Khan <skhan@linuxfoundation.org> | 2024-01-03 09:06:19 -0700 |
| commit | a0b84213f947176ddcd0e96e0751a109f28cde21 (patch) | |
| tree | 62d455556ff4ead7d2417d31774e7e15d73b8057 | |
| parent | 342fb9789267ee3908959bfa136b82e88e2ce918 (diff) | |
kunit: Fix NULL-dereference in kunit_init_suite() if suite->log is NULL
suite->log must be checked for NULL before passing it to
string_stream_clear(). This was done in kunit_init_test() but was missing
from kunit_init_suite().
Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com>
Fixes: 6d696c4695c5 ("kunit: add ability to run tests after boot using debugfs")
Reviewed-by: Rae Moar <rmoar@google.com>
Acked-by: David Gow <davidgow@google.com>
Reviewed-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
| -rw-r--r-- | lib/kunit/test.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/lib/kunit/test.c b/lib/kunit/test.c index 3a3d4ebb35db..f95d2093a0aa 100644 --- a/lib/kunit/test.c +++ b/lib/kunit/test.c @@ -697,7 +697,9 @@ static void kunit_init_suite(struct kunit_suite *suite) kunit_debugfs_create_suite(suite); suite->status_comment[0] = '\0'; suite->suite_init_err = 0; - string_stream_clear(suite->log); + + if (suite->log) + string_stream_clear(suite->log); } bool kunit_enabled(void) |