diff options
author | Ilya Dryomov <idryomov@gmail.com> | 2019-02-05 20:30:27 +0100 |
---|---|---|
committer | Ilya Dryomov <idryomov@gmail.com> | 2019-02-18 18:05:33 +0100 |
commit | 0fd3fd0a9bb0b02b6435bb7070e9f7b82a23f068 (patch) | |
tree | 07cd4e55be55374bfd563067e84d9c0dd1ecce58 /.gitignore | |
parent | a3b22b9f11d9fbc48b0291ea92259a5a810e9438 (diff) |
libceph: handle an empty authorize reply
The authorize reply can be empty, for example when the ticket used to
build the authorizer is too old and TAG_BADAUTHORIZER is returned from
the service. Calling ->verify_authorizer_reply() results in an attempt
to decrypt and validate (somewhat) random data in au->buf (most likely
the signature block from calc_signature()), which fails and ends up in
con_fault_finish() with !con->auth_retry. The ticket isn't invalidated
and the connection is retried again and again until a new ticket is
obtained from the monitor:
libceph: osd2 192.168.122.1:6809 bad authorize reply
libceph: osd2 192.168.122.1:6809 bad authorize reply
libceph: osd2 192.168.122.1:6809 bad authorize reply
libceph: osd2 192.168.122.1:6809 bad authorize reply
Let TAG_BADAUTHORIZER handler kick in and increment con->auth_retry.
Cc: stable@vger.kernel.org
Fixes: 5c056fdc5b47 ("libceph: verify authorize reply on connect")
Link: https://tracker.ceph.com/issues/20164
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
Reviewed-by: Sage Weil <sage@redhat.com>
Diffstat (limited to '.gitignore')
0 files changed, 0 insertions, 0 deletions